Closed
Bug 1241884
Opened 9 years ago
Closed 9 years ago
Test API: allow setting request headers for XHR
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: Honza, Assigned: Honza)
References
Details
Attachments
(1 file)
|
2.74 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
It isn't currently possible to set request header for XHRs in tests.
Related existing API:
promiseXHR() : frame-script-utils.js
Honza
|
Assignee | |
Comment 1•9 years ago
|
||
@jryans: what do you think?
Honza
Attachment #8710998 -
Flags: review?(jryans)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8710998 [details] [diff] [review]
bug1241884.patch
Review of attachment 8710998 [details] [diff] [review]:
-----------------------------------------------------------------
Seems fine!
Attachment #8710998 -
Flags: review?(jryans) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Thank for the review!
Honza
Assignee: nobody → odvarko
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
|
||
Comment 7•9 years ago
|
||
[bugday-20160323]
Status: RESOLVED,FIXED -> UNVERIFIED
Comments:
STR: Not clear.
Developer specific testing
Component:
Name Firefox
Version 46.0b9
Build ID 20160322075646
Update Channel beta
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS Windows 7 SP1 x86_64
Expected Results:
Developer specific testing
Actual Results:
As expected
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•